svn commit: samba r14090 - in branches/SAMBA_3_0/source/rpc_parse: .
jra at samba.org
jra at samba.org
Thu Mar 9 19:13:56 GMT 2006
Author: jra
Date: 2006-03-09 19:13:55 +0000 (Thu, 09 Mar 2006)
New Revision: 14090
WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=14090
Log:
Fix coverity bug #21, don't deref potential null.
Jeremy.
Modified:
branches/SAMBA_3_0/source/rpc_parse/parse_samr.c
Changeset:
Modified: branches/SAMBA_3_0/source/rpc_parse/parse_samr.c
===================================================================
--- branches/SAMBA_3_0/source/rpc_parse/parse_samr.c 2006-03-09 19:03:39 UTC (rev 14089)
+++ branches/SAMBA_3_0/source/rpc_parse/parse_samr.c 2006-03-09 19:13:55 UTC (rev 14090)
@@ -5972,7 +5972,11 @@
copy_unistr2(&usr->uni_munged_dial, mung_dial);
init_uni_hdr(&usr->hdr_munged_dial, &usr->uni_munged_dial);
- memcpy(&usr->logon_hrs, hrs, sizeof(usr->logon_hrs));
+ if (hrs) {
+ memcpy(&usr->logon_hrs, hrs, sizeof(usr->logon_hrs));
+ } else {
+ ZERO_STRUCT(usr->logon_hrs);
+ }
}
/*************************************************************************
More information about the samba-cvs
mailing list