svn commit: samba r14047 - in branches/SAMBA_3_0/source/rpc_parse: .

jra at samba.org jra at samba.org
Wed Mar 8 20:07:25 GMT 2006


Author: jra
Date: 2006-03-08 20:07:24 +0000 (Wed, 08 Mar 2006)
New Revision: 14047

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=14047

Log:
Coverity fix #17. Ensure srv_name and info cannot
be zero before deref.
Jeremy.

Modified:
   branches/SAMBA_3_0/source/rpc_parse/parse_spoolss.c


Changeset:
Modified: branches/SAMBA_3_0/source/rpc_parse/parse_spoolss.c
===================================================================
--- branches/SAMBA_3_0/source/rpc_parse/parse_spoolss.c	2006-03-08 20:02:57 UTC (rev 14046)
+++ branches/SAMBA_3_0/source/rpc_parse/parse_spoolss.c	2006-03-08 20:07:24 UTC (rev 14047)
@@ -5061,6 +5061,10 @@
 {
 	DEBUG(5,("make_spoolss_q_addprinterdriver\n"));
 	
+	if (!srv_name || !info) {
+		return False;
+	}
+
 	q_u->server_name_ptr = (srv_name!=NULL)?1:0;
 	init_unistr2(&q_u->server_name, srv_name, UNI_STR_TERMINATE);
 	



More information about the samba-cvs mailing list