svn commit: samba r14045 - in branches/SAMBA_3_0/source/rpc_parse: .
jra at samba.org
jra at samba.org
Wed Mar 8 20:02:50 GMT 2006
Author: jra
Date: 2006-03-08 20:02:50 +0000 (Wed, 08 Mar 2006)
New Revision: 14045
WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=14045
Log:
Coverity fix #14. Ensure if len is set buf != NULL.
Jeremy.
Modified:
branches/SAMBA_3_0/source/rpc_parse/parse_misc.c
Changeset:
Modified: branches/SAMBA_3_0/source/rpc_parse/parse_misc.c
===================================================================
--- branches/SAMBA_3_0/source/rpc_parse/parse_misc.c 2006-03-08 17:50:57 UTC (rev 14044)
+++ branches/SAMBA_3_0/source/rpc_parse/parse_misc.c 2006-03-08 20:02:50 UTC (rev 14045)
@@ -762,6 +762,11 @@
/* set up string lengths. */
SMB_ASSERT(max_len >= str_len);
+ /* Ensure buf is valid if str_len was set. Coverity check. */
+ if (str_len && !buf) {
+ return;
+ }
+
str->str_max_len = max_len;
str->offset = 0;
str->str_str_len = str_len;
More information about the samba-cvs
mailing list