svn commit: samba r14017 - branches/SAMBA_3_0/source/libads trunk/source/libads

[vlendec at samba.org]

Author: vlendec
Date: 2006-03-08 06:32:21 +0000 (Wed, 08 Mar 2006)
New Revision: 14017

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=14017

Log:
Okay, okay, I have turned a double-free into dead code :-)

Fix Coverity # 214.

Volker

Modified:
   branches/SAMBA_3_0/source/libads/ads_ldap.c
   trunk/source/libads/ads_ldap.c


Changeset:
Modified: branches/SAMBA_3_0/source/libads/ads_ldap.c
===================================================================
--- branches/SAMBA_3_0/source/libads/ads_ldap.c	2006-03-08 06:28:08 UTC (rev 14016)
+++ branches/SAMBA_3_0/source/libads/ads_ldap.c	2006-03-08 06:32:21 UTC (rev 14017)
@@ -83,8 +83,6 @@
 	*dn = talloc_strdup(mem_ctx, dn2);
 
 	if (!*dn) {
-		ads_memfree(ads, dn2);
-		dn2 = NULL;
 		rc = ADS_ERROR_NT(NT_STATUS_NO_MEMORY);
 		goto done;
 	}

Modified: trunk/source/libads/ads_ldap.c
===================================================================
--- trunk/source/libads/ads_ldap.c	2006-03-08 06:28:08 UTC (rev 14016)
+++ trunk/source/libads/ads_ldap.c	2006-03-08 06:32:21 UTC (rev 14017)
@@ -83,8 +83,6 @@
 	*dn = talloc_strdup(mem_ctx, dn2);
 
 	if (!*dn) {
-		ads_memfree(ads, dn2);
-		dn2 = NULL;
 		rc = ADS_ERROR_NT(NT_STATUS_NO_MEMORY);
 		goto done;
 	}