svn commit: samba r14014 - in branches/SAMBA_3_0/source/rpc_parse: .

[jra at samba.org]

Author: jra
Date: 2006-03-08 06:16:54 +0000 (Wed, 08 Mar 2006)
New Revision: 14014

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=14014

Log:
Coverity paranoia. Shut it up by making the guarentee
in the code explicit - but this was a false positive (CID #16).
Jeremy.

Modified:
   branches/SAMBA_3_0/source/rpc_parse/parse_buffer.c


Changeset:
Modified: branches/SAMBA_3_0/source/rpc_parse/parse_buffer.c
===================================================================
--- branches/SAMBA_3_0/source/rpc_parse/parse_buffer.c	2006-03-08 05:47:51 UTC (rev 14013)
+++ branches/SAMBA_3_0/source/rpc_parse/parse_buffer.c	2006-03-08 06:16:54 UTC (rev 14014)
@@ -47,7 +47,7 @@
 {
 	prs_debug(ps, depth, desc, "prs_rpcbuffer");
 	depth++;
-		
+
 	/* reading */
 	if (UNMARSHALLING(ps)) {
 		buffer->size=0;
@@ -135,7 +135,12 @@
 		}
 		return True;
 	}
-		
+
+	/* Coverity paranoia. Buffer must be valid. */
+	if (!*buffer) {
+		return False;
+	}
+
 	return prs_rpcbuffer( desc, ps, depth, *buffer);
 }