svn commit: samba r13987 - branches/SAMBA_3_0/source/libsmb trunk/source/libsmb

[vlendec at samba.org]

Author: vlendec
Date: 2006-03-07 20:44:12 +0000 (Tue, 07 Mar 2006)
New Revision: 13987

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=13987

Log:
Fix Coverity bug # 74. This tool is good...

Thanks,

Volker


Modified:
   branches/SAMBA_3_0/source/libsmb/namequery.c
   trunk/source/libsmb/namequery.c


Changeset:
Modified: branches/SAMBA_3_0/source/libsmb/namequery.c
===================================================================
--- branches/SAMBA_3_0/source/libsmb/namequery.c	2006-03-07 20:43:40 UTC (rev 13986)
+++ branches/SAMBA_3_0/source/libsmb/namequery.c	2006-03-07 20:44:12 UTC (rev 13987)
@@ -1126,6 +1126,7 @@
 			/* if it's in the form of an IP address then get the lib to interpret it */
 			if (((*return_iplist)->ip.s_addr = inet_addr(name)) == 0xFFFFFFFF ){
 				DEBUG(1,("internal_resolve_name: inet_addr failed on %s\n", name));
+				SAFE_FREE(*return_iplist);
 				return False;
 			}
 		} else {

Modified: trunk/source/libsmb/namequery.c
===================================================================
--- trunk/source/libsmb/namequery.c	2006-03-07 20:43:40 UTC (rev 13986)
+++ trunk/source/libsmb/namequery.c	2006-03-07 20:44:12 UTC (rev 13987)
@@ -1126,6 +1126,7 @@
 			/* if it's in the form of an IP address then get the lib to interpret it */
 			if (((*return_iplist)->ip.s_addr = inet_addr(name)) == 0xFFFFFFFF ){
 				DEBUG(1,("internal_resolve_name: inet_addr failed on %s\n", name));
+				SAFE_FREE(*return_iplist);
 				return False;
 			}
 		} else {