svn commit: samba r13984 - branches/SAMBA_3_0/source/nsswitch trunk/source/nsswitch

vlendec at samba.org vlendec at samba.org
Tue Mar 7 20:32:08 GMT 2006


Author: vlendec
Date: 2006-03-07 20:32:08 +0000 (Tue, 07 Mar 2006)
New Revision: 13984

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=13984

Log:
Fix Coverity bug # 98
Modified:
   branches/SAMBA_3_0/source/nsswitch/winbindd_cache.c
   trunk/source/nsswitch/winbindd_cache.c


Changeset:
Modified: branches/SAMBA_3_0/source/nsswitch/winbindd_cache.c
===================================================================
--- branches/SAMBA_3_0/source/nsswitch/winbindd_cache.c	2006-03-07 20:24:28 UTC (rev 13983)
+++ branches/SAMBA_3_0/source/nsswitch/winbindd_cache.c	2006-03-07 20:32:08 UTC (rev 13984)
@@ -1469,8 +1469,10 @@
 
 	(*alias_rids) = TALLOC_ARRAY(mem_ctx, uint32, *num_aliases);
 
-	if ((*num_aliases != 0) && ((*alias_rids) == NULL))
+	if ((*num_aliases != 0) && ((*alias_rids) == NULL)) {
+		centry_free(centry);
 		return NT_STATUS_NO_MEMORY;
+	}
 
 	for (i=0; i<(*num_aliases); i++)
 		(*alias_rids)[i] = centry_uint32(centry);

Modified: trunk/source/nsswitch/winbindd_cache.c
===================================================================
--- trunk/source/nsswitch/winbindd_cache.c	2006-03-07 20:24:28 UTC (rev 13983)
+++ trunk/source/nsswitch/winbindd_cache.c	2006-03-07 20:32:08 UTC (rev 13984)
@@ -1469,8 +1469,10 @@
 
 	(*alias_rids) = TALLOC_ARRAY(mem_ctx, uint32, *num_aliases);
 
-	if ((*num_aliases != 0) && ((*alias_rids) == NULL))
+	if ((*num_aliases != 0) && ((*alias_rids) == NULL)) {
+		centry_free(centry);
 		return NT_STATUS_NO_MEMORY;
+	}
 
 	for (i=0; i<(*num_aliases); i++)
 		(*alias_rids)[i] = centry_uint32(centry);



More information about the samba-cvs mailing list