svn commit: samba r13979 - branches/SAMBA_3_0/source/passdb trunk/source/passdb

[vlendec at samba.org]

Author: vlendec
Date: 2006-03-07 19:24:28 +0000 (Tue, 07 Mar 2006)
New Revision: 13979

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=13979

Log:
We've dereferenced my_methods already, so there's no point in checking for 
!= NULL. Coverity #149.

Volker


Modified:
   branches/SAMBA_3_0/source/passdb/pdb_ldap.c
   trunk/source/passdb/pdb_ldap.c


Changeset:
Modified: branches/SAMBA_3_0/source/passdb/pdb_ldap.c
===================================================================
--- branches/SAMBA_3_0/source/passdb/pdb_ldap.c	2006-03-07 19:18:56 UTC (rev 13978)
+++ branches/SAMBA_3_0/source/passdb/pdb_ldap.c	2006-03-07 19:24:28 UTC (rev 13979)
@@ -1516,7 +1516,7 @@
 	struct ldapsam_privates *ldap_state = (struct ldapsam_privates *)my_methods->private_data;
 	int rc;
 	
-	if (!my_methods || !newpwd || !dn) {
+	if (!newpwd || !dn) {
 		return NT_STATUS_INVALID_PARAMETER;
 	}
 	

Modified: trunk/source/passdb/pdb_ldap.c
===================================================================
--- trunk/source/passdb/pdb_ldap.c	2006-03-07 19:18:56 UTC (rev 13978)
+++ trunk/source/passdb/pdb_ldap.c	2006-03-07 19:24:28 UTC (rev 13979)
@@ -1516,7 +1516,7 @@
 	struct ldapsam_privates *ldap_state = (struct ldapsam_privates *)my_methods->private_data;
 	int rc;
 	
-	if (!my_methods || !newpwd || !dn) {
+	if (!newpwd || !dn) {
 		return NT_STATUS_INVALID_PARAMETER;
 	}