svn commit: samba r13958 - branches/SAMBA_3_0/source/rpc_client trunk/source/rpc_client

vlendec at samba.org vlendec at samba.org
Tue Mar 7 16:33:37 GMT 2006


Author: vlendec
Date: 2006-03-07 16:33:36 +0000 (Tue, 07 Mar 2006)
New Revision: 13958

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=13958

Log:
Fix Coverity Bug # 141
Modified:
   branches/SAMBA_3_0/source/rpc_client/cli_spoolss.c
   trunk/source/rpc_client/cli_spoolss.c


Changeset:
Modified: branches/SAMBA_3_0/source/rpc_client/cli_spoolss.c
===================================================================
--- branches/SAMBA_3_0/source/rpc_client/cli_spoolss.c	2006-03-07 16:29:25 UTC (rev 13957)
+++ branches/SAMBA_3_0/source/rpc_client/cli_spoolss.c	2006-03-07 16:33:36 UTC (rev 13958)
@@ -384,7 +384,7 @@
 	int i;
 
 	*forms = TALLOC_ARRAY(mem_ctx, FORM_1, num_forms);
-	if (!forms) {
+	if (*forms == NULL) {
 		return False;
 	}
 	prs_set_offset(&buffer->prs,0);

Modified: trunk/source/rpc_client/cli_spoolss.c
===================================================================
--- trunk/source/rpc_client/cli_spoolss.c	2006-03-07 16:29:25 UTC (rev 13957)
+++ trunk/source/rpc_client/cli_spoolss.c	2006-03-07 16:33:36 UTC (rev 13958)
@@ -384,7 +384,7 @@
 	int i;
 
 	*forms = TALLOC_ARRAY(mem_ctx, FORM_1, num_forms);
-	if (!forms) {
+	if (*forms == NULL) {
 		return False;
 	}
 	prs_set_offset(&buffer->prs,0);



More information about the samba-cvs mailing list