svn commit: samba r13955 - branches/SAMBA_3_0/source/groupdb trunk/source/groupdb

[vlendec at samba.org]

Author: vlendec
Date: 2006-03-07 16:28:05 +0000 (Tue, 07 Mar 2006)
New Revision: 13955

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=13955

Log:
Fix Coverity ID 139.

Not a bug in the strictest sense, more a clarification. This whole routine
assumes new_gid != NULL anyway, so there's no point in checking.

Volker


Modified:
   branches/SAMBA_3_0/source/groupdb/mapping.c
   trunk/source/groupdb/mapping.c


Changeset:
Modified: branches/SAMBA_3_0/source/groupdb/mapping.c
===================================================================
--- branches/SAMBA_3_0/source/groupdb/mapping.c	2006-03-07 16:27:01 UTC (rev 13954)
+++ branches/SAMBA_3_0/source/groupdb/mapping.c	2006-03-07 16:28:05 UTC (rev 13955)
@@ -868,7 +868,7 @@
 	if ( *lp_addgroup_script() ) {
 		pstrcpy(add_script, lp_addgroup_script());
 		pstring_sub(add_script, "%g", unix_group);
-		ret = smbrun(add_script, (new_gid!=NULL) ? &fd : NULL);
+		ret = smbrun(add_script, &fd);
 		DEBUG(ret ? 0 : 3,("smb_create_group: Running the command `%s' gave %d\n",add_script,ret));
 		if (ret != 0)
 			return ret;

Modified: trunk/source/groupdb/mapping.c
===================================================================
--- trunk/source/groupdb/mapping.c	2006-03-07 16:27:01 UTC (rev 13954)
+++ trunk/source/groupdb/mapping.c	2006-03-07 16:28:05 UTC (rev 13955)
@@ -868,7 +868,7 @@
 	if ( *lp_addgroup_script() ) {
 		pstrcpy(add_script, lp_addgroup_script());
 		pstring_sub(add_script, "%g", unix_group);
-		ret = smbrun(add_script, (new_gid!=NULL) ? &fd : NULL);
+		ret = smbrun(add_script, &fd);
 		DEBUG(ret ? 0 : 3,("smb_create_group: Running the command `%s' gave %d\n",add_script,ret));
 		if (ret != 0)
 			return ret;