svn commit: samba r13891 - in trunk/source/nmbd: .

jra at samba.org jra at samba.org
Mon Mar 6 20:05:13 GMT 2006


Author: jra
Date: 2006-03-06 20:05:12 +0000 (Mon, 06 Mar 2006)
New Revision: 13891

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=13891

Log:
Doh ! My bugfix had a bug :-). Spotted by  Willi Mann <willi at wm1.at>,
if rrec can be null make sure we *never* deref it.
Jeremy.

Modified:
   trunk/source/nmbd/nmbd_winsproxy.c


Changeset:
Modified: trunk/source/nmbd/nmbd_winsproxy.c
===================================================================
--- trunk/source/nmbd/nmbd_winsproxy.c	2006-03-06 19:48:07 UTC (rev 13890)
+++ trunk/source/nmbd/nmbd_winsproxy.c	2006-03-06 20:05:12 UTC (rev 13891)
@@ -47,11 +47,11 @@
 	memcpy( (char *)&original_packet, &userdata->data[sizeof(struct subnet_record *)],
 			sizeof(struct packet_struct *) );
 
-	nb_flags = get_nb_flags( rrec->rdata );
-
 	if (rrec) {
+		nb_flags = get_nb_flags( rrec->rdata );
 		num_ips = rrec->rdlength / 6;
 	} else {
+		nb_flags = 0;
 		num_ips = 0;
 	}
 



More information about the samba-cvs mailing list