svn commit: samba r13871 - in trunk/source/locking: .

jra at samba.org jra at samba.org
Mon Mar 6 16:39:51 GMT 2006


Author: jra
Date: 2006-03-06 16:39:50 +0000 (Mon, 06 Mar 2006)
New Revision: 13871

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=13871

Log:
Fix first of the Coverity bugs. Check for NULL
deref. CID #195. Thanks Coverity !
Jeremy.

Modified:
   trunk/source/locking/locking.c


Changeset:
Modified: trunk/source/locking/locking.c
===================================================================
--- trunk/source/locking/locking.c	2006-03-06 16:19:27 UTC (rev 13870)
+++ trunk/source/locking/locking.c	2006-03-06 16:39:50 UTC (rev 13871)
@@ -101,6 +101,9 @@
 			ret = False;
 		} else {
 			struct byte_range_lock *br_lck = brl_get_locks(NULL, fsp);
+			if (!brl_lock) {
+				return False;
+			}
 			ret = !brl_locktest(br_lck,
 					global_smbpid,
 					procid_self(),
@@ -112,6 +115,9 @@
 		}
 	} else {
 		struct byte_range_lock *br_lck = brl_get_locks(NULL, fsp);
+		if (!brl_lock) {
+			return False;
+		}
 		ret = !brl_locktest(br_lck,
 				global_smbpid,
 				procid_self(),



More information about the samba-cvs mailing list