svn commit: samba r16466 - in branches/SAMBA_4_0/source/smb_server:
.
metze at samba.org
metze at samba.org
Thu Jun 22 17:33:56 GMT 2006
Author: metze
Date: 2006-06-22 17:33:56 +0000 (Thu, 22 Jun 2006)
New Revision: 16466
WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=16466
Log:
for SMB2_ALL_EAS it's not valid for the ntvfs backends to return
0 eas, they should return an error:
NO_EAS_ON_FILE or NO_MORE_EAS
metze
Modified:
branches/SAMBA_4_0/source/smb_server/blob.c
Changeset:
Modified: branches/SAMBA_4_0/source/smb_server/blob.c
===================================================================
--- branches/SAMBA_4_0/source/smb_server/blob.c 2006-06-22 17:25:50 UTC (rev 16465)
+++ branches/SAMBA_4_0/source/smb_server/blob.c 2006-06-22 17:33:56 UTC (rev 16466)
@@ -444,6 +444,15 @@
return NT_STATUS_OK;
case RAW_FILEINFO_SMB2_ALL_EAS:
+ /* if no eas are returned the backend should
+ * have returned NO_EAS_ON_FILE or NO_MORE_EAS
+ *
+ * so it's a programmer error if num_eas == 0
+ */
+ if (st->all_eas.out.num_eas == 0) {
+ smb_panic("0 eas for SMB2_ALL_EAS - programmer error in ntvfs backend");
+ }
+
list_size = ea_list_size_chained(st->all_eas.out.num_eas,
st->all_eas.out.eas);
BLOB_CHECK(smbsrv_blob_grow_data(mem_ctx, blob, list_size));
More information about the samba-cvs
mailing list