svn commit: samba r16393 - in branches/SAMBA_3_0/source/printing: .

jra at samba.org jra at samba.org
Tue Jun 20 01:27:40 GMT 2006


Author: jra
Date: 2006-06-20 01:27:39 +0000 (Tue, 20 Jun 2006)
New Revision: 16393

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=16393

Log:
Klocwork #1164. Null deref.
Jeremy.

Modified:
   branches/SAMBA_3_0/source/printing/print_generic.c


Changeset:
Modified: branches/SAMBA_3_0/source/printing/print_generic.c
===================================================================
--- branches/SAMBA_3_0/source/printing/print_generic.c	2006-06-20 01:25:31 UTC (rev 16392)
+++ branches/SAMBA_3_0/source/printing/print_generic.c	2006-06-20 01:27:39 UTC (rev 16393)
@@ -193,7 +193,7 @@
 	/* turn the lpq output into a series of job structures */
 	qcount = 0;
 	ZERO_STRUCTP(status);
-	if (numlines) {
+	if (numlines && qlines) {
 		queue = SMB_MALLOC_ARRAY(print_queue_struct, numlines+1);
 		if (!queue) {
 			file_lines_free(qlines);



More information about the samba-cvs mailing list