svn commit: samba r16376 - in trunk/source/rpc_parse: .

jra at samba.org jra at samba.org
Mon Jun 19 23:21:41 GMT 2006


Author: jra
Date: 2006-06-19 23:21:41 +0000 (Mon, 19 Jun 2006)
New Revision: 16376

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=16376

Log:
Klocwork #1077.
Jeremy.

Modified:
   trunk/source/rpc_parse/parse_spoolss.c


Changeset:
Modified: trunk/source/rpc_parse/parse_spoolss.c
===================================================================
--- trunk/source/rpc_parse/parse_spoolss.c	2006-06-19 23:19:24 UTC (rev 16375)
+++ trunk/source/rpc_parse/parse_spoolss.c	2006-06-19 23:21:41 UTC (rev 16376)
@@ -5005,11 +5005,16 @@
 		rpcstr_pull(f, src, sizeof(f)-1, -1, STR_TERMINATE);
 		src = skip_unibuf(src, 2*buf5->buf_len - PTR_DIFF(src,buf5->buffer));
 		*ar = SMB_REALLOC_ARRAY(*ar, fstring, n+2);
-		if (!*ar)
+		if (!*ar) {
 			return False;
+		}
 		fstrcpy((*ar)[n], f);
 		n++;
 	}
+	if (!*ar) {
+		return False;
+	}
+
 	fstrcpy((*ar)[n], "");
  
 	return True;



More information about the samba-cvs mailing list