svn commit: samba r16363 - branches/SAMBA_3_0/source/libsmb branches/SAMBA_3_0/source/utils trunk/source/libsmb trunk/source/utils

vlendec at samba.org vlendec at samba.org
Mon Jun 19 20:00:51 GMT 2006


Author: vlendec
Date: 2006-06-19 20:00:51 +0000 (Mon, 19 Jun 2006)
New Revision: 16363

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=16363

Log:
Fix Klocwork ID 981 1652

Volker

Modified:
   branches/SAMBA_3_0/source/libsmb/trusts_util.c
   branches/SAMBA_3_0/source/utils/ntlm_auth_diagnostics.c
   trunk/source/libsmb/trusts_util.c
   trunk/source/utils/ntlm_auth_diagnostics.c


Changeset:
Modified: branches/SAMBA_3_0/source/libsmb/trusts_util.c
===================================================================
--- branches/SAMBA_3_0/source/libsmb/trusts_util.c	2006-06-19 19:56:22 UTC (rev 16362)
+++ branches/SAMBA_3_0/source/libsmb/trusts_util.c	2006-06-19 20:00:51 UTC (rev 16363)
@@ -86,7 +86,11 @@
 		
 	/* Create a random machine account password */
 	str = generate_random_str(DEFAULT_TRUST_ACCOUNT_PASSWORD_LENGTH);
-	new_trust_passwd = talloc_strdup(mem_ctx, str);
+
+	if ((new_trust_passwd = talloc_strdup(mem_ctx, str)) == NULL) {
+		DEBUG(0, ("talloc_strdup failed\n"));
+		return NT_STATUS_NO_MEMORY;
+	}
 	
 	E_md4hash(new_trust_passwd, new_trust_passwd_hash);
 

Modified: branches/SAMBA_3_0/source/utils/ntlm_auth_diagnostics.c
===================================================================
--- branches/SAMBA_3_0/source/utils/ntlm_auth_diagnostics.c	2006-06-19 19:56:22 UTC (rev 16362)
+++ branches/SAMBA_3_0/source/utils/ntlm_auth_diagnostics.c	2006-06-19 20:00:51 UTC (rev 16363)
@@ -464,7 +464,10 @@
 
 	nt_response.length = strlen_w(((void *)nt_response.data))*sizeof(smb_ucs2_t);
 
-	password = strdup_upper(opt_password);
+	if ((password = strdup_upper(opt_password)) == NULL) {
+		DEBUG(0, ("strdup_upper failed!\n"));
+		exit(1);
+	}
 
 	if ((convert_string_allocate(NULL, CH_UNIX, 
 				     CH_DOS, password,

Modified: trunk/source/libsmb/trusts_util.c
===================================================================
--- trunk/source/libsmb/trusts_util.c	2006-06-19 19:56:22 UTC (rev 16362)
+++ trunk/source/libsmb/trusts_util.c	2006-06-19 20:00:51 UTC (rev 16363)
@@ -86,7 +86,11 @@
 		
 	/* Create a random machine account password */
 	str = generate_random_str(DEFAULT_TRUST_ACCOUNT_PASSWORD_LENGTH);
-	new_trust_passwd = talloc_strdup(mem_ctx, str);
+
+	if ((new_trust_passwd = talloc_strdup(mem_ctx, str)) == NULL) {
+		DEBUG(0, ("talloc_strdup failed\n"));
+		return NT_STATUS_NO_MEMORY;
+	}
 	
 	E_md4hash(new_trust_passwd, new_trust_passwd_hash);
 

Modified: trunk/source/utils/ntlm_auth_diagnostics.c
===================================================================
--- trunk/source/utils/ntlm_auth_diagnostics.c	2006-06-19 19:56:22 UTC (rev 16362)
+++ trunk/source/utils/ntlm_auth_diagnostics.c	2006-06-19 20:00:51 UTC (rev 16363)
@@ -464,7 +464,10 @@
 
 	nt_response.length = strlen_w(((void *)nt_response.data))*sizeof(smb_ucs2_t);
 
-	password = strdup_upper(opt_password);
+	if ((password = strdup_upper(opt_password)) == NULL) {
+		DEBUG(0, ("strdup_upper failed!\n"));
+		exit(1);
+	}
 
 	if ((convert_string_allocate(NULL, CH_UNIX, 
 				     CH_DOS, password,



More information about the samba-cvs mailing list