svn commit: samba r16320 - in branches/SAMBA_3_0/source/lib: .

jra at samba.org jra at samba.org
Fri Jun 16 23:07:42 GMT 2006


Author: jra
Date: 2006-06-16 23:07:42 +0000 (Fri, 16 Jun 2006)
New Revision: 16320

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=16320

Log:
Ensure variable is not null before calling fclose.
Klocwork #412.
Jeremy.

Modified:
   branches/SAMBA_3_0/source/lib/getsmbpass.c


Changeset:
Modified: branches/SAMBA_3_0/source/lib/getsmbpass.c
===================================================================
--- branches/SAMBA_3_0/source/lib/getsmbpass.c	2006-06-16 23:07:24 UTC (rev 16319)
+++ branches/SAMBA_3_0/source/lib/getsmbpass.c	2006-06-16 23:07:42 UTC (rev 16320)
@@ -163,7 +163,7 @@
 	fprintf(out, "\n");
 	fflush(out);
 
-	if (in != stdin) /* We opened the terminal; now close it.  */
+	if (in && in != stdin) /* We opened the terminal; now close it.  */
 		fclose(in);
 
 	/* Catch problematic signals */



More information about the samba-cvs mailing list