svn commit: samba r16065 - branches/SAMBA_3_0/source/rpc_server trunk/source/rpc_server

[vlendec at samba.org]

Author: vlendec
Date: 2006-06-06 20:34:26 +0000 (Tue, 06 Jun 2006)
New Revision: 16065

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=16065

Log:
Re-add a strlower_m(account) in samr_create_user that was dropped for no
reason but to increase fidelity with W2k3. Tom Bork has raised valid concerns
that Unix scripts might rely on the account names being lower-case, so keep
that. We might later decide to only lower-case the unix name passed to 
'add [user|group] script' but keep the passdb entry upper-case. But there are
enough user-visible changes in 3_0 already so that we should push this off to
a later date.

Tom, waiting for more bug reports from you ;-))

Thanks for insisting!

Volker

Modified:
   branches/SAMBA_3_0/source/rpc_server/srv_samr_nt.c
   trunk/source/rpc_server/srv_samr_nt.c


Changeset:
Modified: branches/SAMBA_3_0/source/rpc_server/srv_samr_nt.c
===================================================================
--- branches/SAMBA_3_0/source/rpc_server/srv_samr_nt.c	2006-06-06 20:18:11 UTC (rev 16064)
+++ branches/SAMBA_3_0/source/rpc_server/srv_samr_nt.c	2006-06-06 20:34:26 UTC (rev 16065)
@@ -2463,6 +2463,8 @@
 		return NT_STATUS_NO_MEMORY;
 	}
 
+	strlower_m(account);
+
 	nt_status = can_create(p->mem_ctx, account);
 	if (!NT_STATUS_IS_OK(nt_status)) {
 		return nt_status;

Modified: trunk/source/rpc_server/srv_samr_nt.c
===================================================================
--- trunk/source/rpc_server/srv_samr_nt.c	2006-06-06 20:18:11 UTC (rev 16064)
+++ trunk/source/rpc_server/srv_samr_nt.c	2006-06-06 20:34:26 UTC (rev 16065)
@@ -2463,6 +2463,8 @@
 		return NT_STATUS_NO_MEMORY;
 	}
 
+	strlower_m(account);
+
 	nt_status = can_create(p->mem_ctx, account);
 	if (!NT_STATUS_IS_OK(nt_status)) {
 		return nt_status;