svn commit: samba r17183 - in branches: SAMBA_3_0/source/rpc_server SAMBA_3_0_23/source/rpc_server

[jerry at samba.org]

Author: jerry
Date: 2006-07-22 00:53:19 +0000 (Sat, 22 Jul 2006)
New Revision: 17183

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=17183

Log:
LsaLookupSids() shoudl return the string form of a SID when 
it cannot be mapped and not the hex of the RID.  Who wrote that?



Modified:
   branches/SAMBA_3_0/source/rpc_server/srv_lsa_nt.c
   branches/SAMBA_3_0_23/source/rpc_server/srv_lsa_nt.c


Changeset:
Modified: branches/SAMBA_3_0/source/rpc_server/srv_lsa_nt.c
===================================================================
--- branches/SAMBA_3_0/source/rpc_server/srv_lsa_nt.c	2006-07-22 00:52:28 UTC (rev 17182)
+++ branches/SAMBA_3_0/source/rpc_server/srv_lsa_nt.c	2006-07-22 00:53:19 UTC (rev 17183)
@@ -873,8 +873,9 @@
 
 		if (name->type == SID_NAME_UNKNOWN) {
 			name->dom_idx = -1;
-			name->name = talloc_asprintf(p->mem_ctx, "%8.8x",
-						     name->rid);
+			/* unknown sids should return the string representation of the SID */
+			name->name = talloc_asprintf(p->mem_ctx, "%s", 
+			                             sid_string_static(sids[i]));
 			if (name->name == NULL) {
 				return NT_STATUS_NO_MEMORY;
 			}

Modified: branches/SAMBA_3_0_23/source/rpc_server/srv_lsa_nt.c
===================================================================
--- branches/SAMBA_3_0_23/source/rpc_server/srv_lsa_nt.c	2006-07-22 00:52:28 UTC (rev 17182)
+++ branches/SAMBA_3_0_23/source/rpc_server/srv_lsa_nt.c	2006-07-22 00:53:19 UTC (rev 17183)
@@ -873,8 +873,9 @@
 
 		if (name->type == SID_NAME_UNKNOWN) {
 			name->dom_idx = -1;
-			name->name = talloc_asprintf(p->mem_ctx, "%8.8x",
-						     name->rid);
+			/* unknown sids should return the string representation of the SID */
+			name->name = talloc_asprintf(p->mem_ctx, "%s", 
+			                             sid_string_static(sids[i]));
 			if (name->name == NULL) {
 				return NT_STATUS_NO_MEMORY;
 			}