svn commit: samba r17055 - in branches/SOC/mkhl/ldb-map/modules: .

mkhl at samba.org mkhl at samba.org
Sat Jul 15 09:16:42 GMT 2006


Author: mkhl
Date: 2006-07-15 09:16:41 +0000 (Sat, 15 Jul 2006)
New Revision: 17055

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=17055

Log:
Don't talloc_zero structures whose contents will be completely
overwritten anyway.

Martin

Modified:
   branches/SOC/mkhl/ldb-map/modules/ldb_map.c


Changeset:
Modified: branches/SOC/mkhl/ldb-map/modules/ldb_map.c
===================================================================
--- branches/SOC/mkhl/ldb-map/modules/ldb_map.c	2006-07-15 09:13:29 UTC (rev 17054)
+++ branches/SOC/mkhl/ldb-map/modules/ldb_map.c	2006-07-15 09:16:41 UTC (rev 17055)
@@ -2140,7 +2140,7 @@
 	req->async.handle = h;
 
 	/* prepare the local operation */
-	ac->local_req = talloc_zero(ac, struct ldb_request);
+	ac->local_req = talloc(ac, struct ldb_request);
 	if (ac->local_req == NULL) {
 		map_oom(module);
 		return LDB_ERR_OPERATIONS_ERROR;
@@ -2152,7 +2152,7 @@
 	ac->local_req->async.callback = NULL;
 
 	/* prepare the remote operation */
-	ac->remote_req = talloc_zero(ac, struct ldb_request);
+	ac->remote_req = talloc(ac, struct ldb_request);
 	if (ac->remote_req == NULL) {
 		talloc_free(ac->local_req);
 		map_oom(module);
@@ -2303,7 +2303,7 @@
 	req->async.handle = h;
 
 	/* prepare the local operation */
-	ac->local_req = talloc_zero(ac, struct ldb_request);
+	ac->local_req = talloc(ac, struct ldb_request);
 	if (ac->local_req == NULL) {
 		map_oom(module);
 		return LDB_ERR_OPERATIONS_ERROR;
@@ -2315,7 +2315,7 @@
 	ac->local_req->async.callback = NULL;
 
 	/* prepare the remote operation */
-	ac->remote_req = talloc_zero(ac, struct ldb_request);
+	ac->remote_req = talloc(ac, struct ldb_request);
 	if (ac->remote_req == NULL) {
 		talloc_free(ac->local_req);
 		map_oom(module);
@@ -2377,7 +2377,7 @@
 	ac = talloc_get_type(handle->private_data, struct map_async_context);
 
 	/* prepare the local operation */
-	ac->local_req = talloc_zero(ac, struct ldb_request);
+	ac->local_req = talloc(ac, struct ldb_request);
 	if (ac->local_req == NULL) {
 		ldb_oom(ac->module->ldb);
 		return LDB_ERR_OPERATIONS_ERROR;
@@ -2412,7 +2412,7 @@
 		return map_delete_do_local(handle);
 
 	/* prepare the remote operation */
-	ac->remote_req = talloc_zero(ac, struct ldb_request);
+	ac->remote_req = talloc(ac, struct ldb_request);
 	if (ac->remote_req == NULL) {
 		ldb_oom(ac->module->ldb);
 		return LDB_ERR_OPERATIONS_ERROR;
@@ -2484,7 +2484,7 @@
 	ac = talloc_get_type(handle->private_data, struct map_async_context);
 
 	/* prepare the local operation */
-	ac->local_req = talloc_zero(ac, struct ldb_request);
+	ac->local_req = talloc(ac, struct ldb_request);
 	if (ac->local_req == NULL) {
 		ldb_oom(ac->module->ldb);
 		return LDB_ERR_OPERATIONS_ERROR;
@@ -2574,7 +2574,7 @@
 		return map_rename_do_local(handle);
 
 	/* prepare the remote operation */
-	ac->remote_req = talloc_zero(ac, struct ldb_request);
+	ac->remote_req = talloc(ac, struct ldb_request);
 	if (ac->remote_req == NULL) {
 		ldb_oom(ac->module->ldb);
 		return LDB_ERR_OPERATIONS_ERROR;



More information about the samba-cvs mailing list