svn commit: samba r16795 - in branches/SAMBA_4_0/source/ldap_server: .

[abartlet at samba.org]

Author: abartlet
Date: 2006-07-04 03:32:39 +0000 (Tue, 04 Jul 2006)
New Revision: 16795

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=16795

Log:
Fix crash found by Dave Fenwick <djf at samba.org>.

The session_info was not being attached to the connection, so
subsequent checks in the kludge_acl module were looking at free()ed
memory.

Andrew Bartlett

Modified:
   branches/SAMBA_4_0/source/ldap_server/ldap_bind.c


Changeset:
Modified: branches/SAMBA_4_0/source/ldap_server/ldap_bind.c
===================================================================
--- branches/SAMBA_4_0/source/ldap_server/ldap_bind.c	2006-07-04 02:46:24 UTC (rev 16794)
+++ branches/SAMBA_4_0/source/ldap_server/ldap_bind.c	2006-07-04 03:32:39 UTC (rev 16795)
@@ -60,6 +60,7 @@
 
 		talloc_free(call->conn->session_info);
 		call->conn->session_info = session_info;
+		talloc_steal(call->conn, session_info);
 
 		/* don't leak the old LDB */
 		talloc_free(call->conn->ldb);
@@ -187,6 +188,7 @@
 			errstr = talloc_asprintf(reply, "SASL:[%s]: Failed to get session info: %s", req->creds.SASL.mechanism, nt_errstr(status));
 		} else {
 			talloc_free(old_session_info);
+			talloc_steal(conn, conn->session_info);
 
 			/* don't leak the old LDB */
 			talloc_free(conn->ldb);