svn commit: samba r16786 - in branches/SAMBA_3_0_RELEASE: . source source/rpc_server

[jerry at samba.org]

Author: jerry
Date: 2006-07-03 16:13:10 +0000 (Mon, 03 Jul 2006)
New Revision: 16786

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=16786

Log:
* merge fix for BUG 3908 (pw change failure)
* create pch file in builddir
* update release notes


Modified:
   branches/SAMBA_3_0_RELEASE/WHATSNEW.txt
   branches/SAMBA_3_0_RELEASE/source/Makefile.in
   branches/SAMBA_3_0_RELEASE/source/rpc_server/srv_pipe.c


Changeset:
Modified: branches/SAMBA_3_0_RELEASE/WHATSNEW.txt
===================================================================
--- branches/SAMBA_3_0_RELEASE/WHATSNEW.txt	2006-07-03 16:12:16 UTC (rev 16785)
+++ branches/SAMBA_3_0_RELEASE/WHATSNEW.txt	2006-07-03 16:13:10 UTC (rev 16786)
@@ -178,6 +178,8 @@
     * Fix broken compile of unsupported smbwrapper utility.
     * BUG 3905: Fix smbd startup failure caused by a failure to
       create an NT token for the guest account.
+    * BUG 3908: Fix RPC bind authentication failure which broke
+      user password changes.
 
 
 o   Guenther Deschner <gd at samba.org>

Modified: branches/SAMBA_3_0_RELEASE/source/Makefile.in
===================================================================
--- branches/SAMBA_3_0_RELEASE/source/Makefile.in	2006-07-03 16:12:16 UTC (rev 16785)
+++ branches/SAMBA_3_0_RELEASE/source/Makefile.in	2006-07-03 16:13:10 UTC (rev 16786)
@@ -851,8 +851,8 @@
 # this adds support for precompiled headers. To use it, install a snapshot
 # of gcc-3.4 and run 'make pch' before you do the main build. 
 pch: proto_exists
-	rm -f $(srcdir)/include/includes.h.gch
-	$(CC) -I. -I$(srcdir) $(FLAGS) @PIE_CFLAGS@ -c $(srcdir)/include/includes.h -o $(srcdir)/include/includes.h.gch
+	rm -f $(builddir)/include/includes.h.gch
+	$(CC) -I. -I$(srcdir) $(FLAGS) @PIE_CFLAGS@ -c $(srcdir)/include/includes.h -o $(builddir)/include/includes.h.gch
 
 # These dependencies are only approximately correct: we want to make
 # sure Samba's paths are updated if ./configure is re-run.  Really it

Modified: branches/SAMBA_3_0_RELEASE/source/rpc_server/srv_pipe.c
===================================================================
--- branches/SAMBA_3_0_RELEASE/source/rpc_server/srv_pipe.c	2006-07-03 16:12:16 UTC (rev 16785)
+++ branches/SAMBA_3_0_RELEASE/source/rpc_server/srv_pipe.c	2006-07-03 16:13:10 UTC (rev 16786)
@@ -620,7 +620,10 @@
 	p->pipe_user.ut.ngroups = 0;
 	SAFE_FREE( p->pipe_user.ut.groups);
 
+	/* this has to be done as root in order to verify the password */
+	become_root();
 	status = auth_ntlmssp_update(a, *p_resp_blob, &reply);
+	unbecome_root();
 
 	/* Don't generate a reply. */
 	data_blob_free(&reply);