svn commit: samba r16749 - branches/SAMBA_3_0/source/auth trunk/source/auth

jerry at samba.org jerry at samba.org
Sat Jul 1 17:55:08 GMT 2006


Author: jerry
Date: 2006-07-01 17:55:07 +0000 (Sat, 01 Jul 2006)
New Revision: 16749

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=16749

Log:
BUG 3905: don't fail in create_local_nt_token() when a 
checking for the builtin Administrators group membership.
security = server has no domain info in secrets.tdb



Modified:
   branches/SAMBA_3_0/source/auth/auth_util.c
   trunk/source/auth/auth_util.c


Changeset:
Modified: branches/SAMBA_3_0/source/auth/auth_util.c
===================================================================
--- branches/SAMBA_3_0/source/auth/auth_util.c	2006-07-01 17:32:15 UTC (rev 16748)
+++ branches/SAMBA_3_0/source/auth/auth_util.c	2006-07-01 17:55:07 UTC (rev 16749)
@@ -876,9 +876,10 @@
 		}
 		else {
 			status = add_builtin_administrators( tmp_ctx, result );	
-			if ( !NT_STATUS_IS_OK(status) ) {			
-				result = NULL;
-				goto done;
+			if ( !NT_STATUS_IS_OK(status) ) {
+				/* just log a complaint but do not fail */
+				DEBUG(3,("create_local_nt_token: failed to check for local Administrators"
+					" membership (%s)\n", nt_errstr(status)));
 			}			
 		}		
 	}

Modified: trunk/source/auth/auth_util.c
===================================================================
--- trunk/source/auth/auth_util.c	2006-07-01 17:32:15 UTC (rev 16748)
+++ trunk/source/auth/auth_util.c	2006-07-01 17:55:07 UTC (rev 16749)
@@ -876,9 +876,10 @@
 		}
 		else {
 			status = add_builtin_administrators( result );
-			if ( !NT_STATUS_IS_OK(status) ) {			
-				TALLOC_FREE(result);
-				return NULL;
+			if ( !NT_STATUS_IS_OK(status) ) {
+				/* just log a complaint but do not fail */
+				DEBUG(3,("create_local_nt_token: failed to check for local Administrators"
+					" membership (%s)\n", nt_errstr(status)));
 			}			
 		}		
 	}



More information about the samba-cvs mailing list