svn commit: samba r16729 - in trunk/source: lib rpc_parse rpc_server

[vlendec at samba.org]

Author: vlendec
Date: 2006-07-01 12:14:45 +0000 (Sat, 01 Jul 2006)
New Revision: 16729

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=16729

Log:
Finally read about the type punned warnings....

http://lists.suse.com/archive/suse-programming/2003-Sep/0052.html starts a
(German, I'm afraid) thread about that topic. One important finding: The GCC
-fstrict-aliasing option that is activates warnings about non-standard-C
assumptions we make in the code about pointer targets.

One result is that we can't use void ** as function parameters, as this is not
covered by the 'can point to anything' exception in the C standard.

This fixes a ton of these warnings (according to the mailthread they are real
bugs) by changing the function prototype of convert_string_allocate and
prs_pointer. More to come.

Volker

Modified:
   trunk/source/lib/charcnv.c
   trunk/source/lib/util_reg.c
   trunk/source/rpc_parse/parse_eventlog.c
   trunk/source/rpc_parse/parse_lsa.c
   trunk/source/rpc_parse/parse_ntsvcs.c
   trunk/source/rpc_parse/parse_prs.c
   trunk/source/rpc_parse/parse_reg.c
   trunk/source/rpc_parse/parse_samr.c
   trunk/source/rpc_parse/parse_shutdown.c
   trunk/source/rpc_parse/parse_spoolss.c
   trunk/source/rpc_parse/parse_srv.c
   trunk/source/rpc_parse/parse_svcctl.c
   trunk/source/rpc_server/srv_samr_nt.c


Changeset:
Sorry, the patch is too large (520 lines) to include; please use WebSVN to see it!
WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=16729