svn commit: samba r12668 - in trunk/source/rpc_server: .

[vlendec at samba.org]

Author: vlendec
Date: 2006-01-01 21:45:02 +0000 (Sun, 01 Jan 2006)
New Revision: 12668

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=12668

Log:
A long-standing bug in lookupsids now popping up: S-1-1-0 and S-1-3-0 both
revert to a domain with NULL name. Now we actually index properly and check
it. With the new code this sent usrmgr into a segfault....

Thanks,

Volker

Modified:
   trunk/source/rpc_server/srv_lsa_nt.c


Changeset:
Modified: trunk/source/rpc_server/srv_lsa_nt.c
===================================================================
--- trunk/source/rpc_server/srv_lsa_nt.c	2006-01-01 20:05:15 UTC (rev 12667)
+++ trunk/source/rpc_server/srv_lsa_nt.c	2006-01-01 21:45:02 UTC (rev 12668)
@@ -103,9 +103,7 @@
 
 	if (dom_name != NULL) {
 		for (num = 0; num < ref->num_ref_doms_1; num++) {
-			fstring domname;
-			rpcstr_pull(domname, ref->ref_dom[num].uni_dom_name.buffer, sizeof(domname), -1, 0);
-			if (strequal(domname, dom_name))
+			if (sid_equal(dom_sid, &ref->ref_dom[num].ref_dom.sid))
 				return num;
 		}
 	} else {