svn commit: samba r13315 - in trunk/source/smbd: .

[jra at samba.org]

Author: jra
Date: 2006-02-03 22:10:39 +0000 (Fri, 03 Feb 2006)
New Revision: 13315

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=13315

Log:
This code has been causing problems since 1.9.x I think.
Remove check_for_pipe() - Volker was completely correct.
If it gets re-added it will be in a old open call path, not
in the generic code path.
Jeremy.

Modified:
   trunk/source/smbd/open.c


Changeset:
Modified: trunk/source/smbd/open.c
===================================================================
--- trunk/source/smbd/open.c	2006-02-03 22:10:37 UTC (rev 13314)
+++ trunk/source/smbd/open.c	2006-02-03 22:10:39 UTC (rev 13315)
@@ -74,24 +74,7 @@
 	return fd_close_posix(conn, fsp);
 }
 
-
 /****************************************************************************
- Check a filename for the pipe string.
-****************************************************************************/
-
-static void check_for_pipe(const char *fname)
-{
-	/* special case of pipe opens */
-	char s[10];
-	StrnCpy(s,fname,sizeof(s)-1);
-	strlower_m(s);
-	if (strstr(s,"pipe/")) {
-		DEBUG(3,("Rejecting named pipe open for %s\n",fname));
-		set_saved_error_triple(ERRSRV, ERRaccess, NT_STATUS_ACCESS_DENIED);
-	}
-}
-
-/****************************************************************************
  Change the ownership of a file to that of the parent directory.
  Do this by fd if possible.
 ****************************************************************************/
@@ -227,7 +210,6 @@
 		/* It's a read-only share - fail if we wanted to write. */
 		if(accmode != O_RDONLY) {
 			DEBUG(3,("Permission denied opening %s\n",fname));
-			check_for_pipe(fname);
 			return False;
 		} else if(flags & O_CREAT) {
 			/* We don't want to write - but we must make sure that
@@ -293,7 +275,6 @@
 			DEBUG(3,("Error opening file %s (%s) (local_flags=%d) "
 				 "(flags=%d)\n",
 				 fname,strerror(errno),local_flags,flags));
-			check_for_pipe(fname);
 			return False;
 		}