svn commit: samba r13305 - in trunk/source/smbd: .

[vlendec at samba.org]

Author: vlendec
Date: 2006-02-03 15:38:31 +0000 (Fri, 03 Feb 2006)
New Revision: 13305

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=13305

Log:
192.168.234.100 is a NT4 machine that exports [temp] as read-only restricted
at the share level. I negotiate lanman1 to get dos error codes.

vlendec at delphin:/etc> smbclient //192.168.234.100/temp -Uvl%asdf -W windows -c
'put hosts \pipe\samr'
Domain=[WINDOWS] OS=[Windows NT 4.0] Server=[NT LAN Manager 4.0]
NT_STATUS_ACCESS_DENIED opening remote file \\pipe\samr
vlendec at delphin:/etc> smbclient //192.168.234.100/temp -Uvl%asdf -W windows -m
lanman1 -c 'put hosts \pipe\samr'
ERRDOS - ERRnoaccess (Access denied.) opening remote file \\pipe\samr

Without this patch Samba misbehaves in the same situation:

vlendec at delphin:/etc> smbclient //192.168.234.1/tmp -Uvl%asdf -W windows -c
'put hosts \pipe\samr' -m lanman1
ERRSRV - ERRaccess ( ... stuff deleted ) opening remote file \\pipe\samr

With this patch we get

ERRDOS - ERRnoaccess (Access denied.) opening remote file \\pipe\samr

which is correct I think.

Jeremy, please check.
Modified:
   trunk/source/smbd/open.c


Changeset:
Modified: trunk/source/smbd/open.c
===================================================================
--- trunk/source/smbd/open.c	2006-02-03 13:11:38 UTC (rev 13304)
+++ trunk/source/smbd/open.c	2006-02-03 15:38:31 UTC (rev 13305)
@@ -227,7 +227,6 @@
 		/* It's a read-only share - fail if we wanted to write. */
 		if(accmode != O_RDONLY) {
 			DEBUG(3,("Permission denied opening %s\n",fname));
-			check_for_pipe(fname);
 			return False;
 		} else if(flags & O_CREAT) {
 			/* We don't want to write - but we must make sure that