svn commit: samba r20426 - in branches/SAMBA_3_0_24/source/libsmb: .

jra at samba.org jra at samba.org
Sun Dec 31 02:22:40 GMT 2006


Author: jra
Date: 2006-12-31 02:22:39 +0000 (Sun, 31 Dec 2006)
New Revision: 20426

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=20426

Log:
Janitor for Volker....
Jeremy.
"Fix a couple of Coverity errors in one run, this was a potential NULL
dereference"

Modified:
   branches/SAMBA_3_0_24/source/libsmb/libsmbclient.c


Changeset:
Modified: branches/SAMBA_3_0_24/source/libsmb/libsmbclient.c
===================================================================
--- branches/SAMBA_3_0_24/source/libsmb/libsmbclient.c	2006-12-30 20:06:27 UTC (rev 20425)
+++ branches/SAMBA_3_0_24/source/libsmb/libsmbclient.c	2006-12-31 02:22:39 UTC (rev 20426)
@@ -4255,11 +4255,14 @@
 			continue;
 		}
 
-                n = strlen(attr_strings.create_time_attr);
-                if (attr_strings.create_time_attr != NULL &&
-                    StrnCaseCmp(tok, attr_strings.create_time_attr, n) == 0) {
-                        dad->create_time = (time_t)strtol(tok+n+1, NULL, 10);
-			continue;
+		if (attr_strings.create_time_attr != NULL) {
+			n = strlen(attr_strings.create_time_attr);
+			if (StrnCaseCmp(tok, attr_strings.create_time_attr,
+					n) == 0) {
+				dad->create_time = (time_t)strtol(tok+n+1,
+								  NULL, 10);
+				continue;
+			}
 		}
 
 		if (StrnCaseCmp(tok, "INODE:", 6) == 0) {



More information about the samba-cvs mailing list