svn commit: samba r20333 - in branches/SAMBA_3_0/source/libsmb: .
vlendec at samba.org
vlendec at samba.org
Sat Dec 23 16:47:50 GMT 2006
Author: vlendec
Date: 2006-12-23 16:47:50 +0000 (Sat, 23 Dec 2006)
New Revision: 20333
WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=20333
Log:
Fix a couple of Coverity errors in one run, this was a potential NULL dereference
Modified:
branches/SAMBA_3_0/source/libsmb/libsmbclient.c
Changeset:
Modified: branches/SAMBA_3_0/source/libsmb/libsmbclient.c
===================================================================
--- branches/SAMBA_3_0/source/libsmb/libsmbclient.c 2006-12-23 10:55:45 UTC (rev 20332)
+++ branches/SAMBA_3_0/source/libsmb/libsmbclient.c 2006-12-23 16:47:50 UTC (rev 20333)
@@ -4246,11 +4246,14 @@
continue;
}
- n = strlen(attr_strings.create_time_attr);
- if (attr_strings.create_time_attr != NULL &&
- StrnCaseCmp(tok, attr_strings.create_time_attr, n) == 0) {
- dad->create_time = (time_t)strtol(tok+n+1, NULL, 10);
- continue;
+ if (attr_strings.create_time_attr != NULL) {
+ n = strlen(attr_strings.create_time_attr);
+ if (StrnCaseCmp(tok, attr_strings.create_time_attr,
+ n) == 0) {
+ dad->create_time = (time_t)strtol(tok+n+1,
+ NULL, 10);
+ continue;
+ }
}
if (StrnCaseCmp(tok, "INODE:", 6) == 0) {
More information about the samba-cvs
mailing list