svn commit: samba r20288 - in branches/SAMBA_4_0/source/librpc/ndr: .

metze at samba.org metze at samba.org
Wed Dec 20 16:58:10 GMT 2006


Author: metze
Date: 2006-12-20 16:58:10 +0000 (Wed, 20 Dec 2006)
New Revision: 20288

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=20288

Log:
fix a mem leak and remove useless code

metze
Modified:
   branches/SAMBA_4_0/source/librpc/ndr/ndr_drsuapi.c


Changeset:
Modified: branches/SAMBA_4_0/source/librpc/ndr/ndr_drsuapi.c
===================================================================
--- branches/SAMBA_4_0/source/librpc/ndr/ndr_drsuapi.c	2006-12-20 16:57:10 UTC (rev 20287)
+++ branches/SAMBA_4_0/source/librpc/ndr/ndr_drsuapi.c	2006-12-20 16:58:10 UTC (rev 20288)
@@ -100,8 +100,8 @@
 				}
 			} else {
 				_OID_PUSH_CHECK(ber_write_OID_String(&blob, r->oid));
-				talloc_steal(ndr, blob.data);
 			}
+			talloc_steal(ndr, blob.data);
 
 			NDR_CHECK(ndr_push_uint32(ndr, NDR_SCALARS, blob.length));
 			NDR_CHECK(ndr_push_array_uint8(ndr, NDR_SCALARS, blob.data, blob.length));
@@ -145,8 +145,6 @@
 				NT_STATUS_HAVE_NO_MEMORY(_oid);
 			} else {
 				_OID_PULL_CHECK(ber_read_OID_String(_oid_array, &_oid));
-				talloc_steal(r->oid, _oid);
-				r->oid = _oid;
 			}
 			data_blob_free(&_oid_array);
 			talloc_steal(r->oid, _oid);



More information about the samba-cvs mailing list