svn commit: samba r20222 - in branches/SAMBA_4_0/source/libnet: .

mimir at samba.org mimir at samba.org
Sun Dec 17 13:01:35 GMT 2006


Author: mimir
Date: 2006-12-17 13:01:35 +0000 (Sun, 17 Dec 2006)
New Revision: 20222

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=20222

Log:
return status unsuccessful when null pointers are returned
from lookup call.


rafal


Modified:
   branches/SAMBA_4_0/source/libnet/libnet_lookup.c


Changeset:
Modified: branches/SAMBA_4_0/source/libnet/libnet_lookup.c
===================================================================
--- branches/SAMBA_4_0/source/libnet/libnet_lookup.c	2006-12-17 02:19:56 UTC (rev 20221)
+++ branches/SAMBA_4_0/source/libnet/libnet_lookup.c	2006-12-17 13:01:35 UTC (rev 20222)
@@ -418,7 +418,9 @@
 			struct lsa_RefDomainList *domains = s->lookup.out.domains;
 			struct lsa_TransSidArray *sids = s->lookup.out.sids;
 
-			/* TODO: verify if returned pointers are non-null */
+			if (domains == NULL || sids == NULL) {
+				composite_error(c, NT_STATUS_UNSUCCESSFUL);
+			}
 
 			if (sids->count > 0) {
 				io->out.rid        = sids->sids[0].rid;



More information about the samba-cvs mailing list