svn commit: samba r20098 - in branches: SAMBA_3_0/source/auth SAMBA_3_0/source/include SAMBA_3_0/source/smbd SAMBA_3_0_24/source/auth SAMBA_3_0_24/source/include SAMBA_3_0_24/source/smbd

[James Peach]

On 09/12/2006, at 9:23 PM, jra at samba.org wrote:

> Author: jra
> Date: 2006-12-10 05:23:47 +0000 (Sun, 10 Dec 2006)
> New Revision: 20098
>
> WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi? 
> view=rev&root=samba&rev=20098
>
> Log:
> Properly fix issues with create_token_from_username()
> reported by James. Ensure that this function allocates
> everything on the temporary context except the return
> memory. Never call this with a null mem context, and
> now use conn->mem_ctx instead in smbd/service.c.
> Remove separate free functions for conn->ngroups
> and conn->nt_user_token as they are now always
> talloc'ed off the conn->mem_ctx. Future optimization
> will be to remove conn->mem_ctx and make all objects
> pointed to in the conn struct talloc'ed off conn itself.
> Easy to free then :-).

Thanks, this looks good!

--
James Peach | jpeach at samba.org