svn commit: samba r20090 - in branches: SAMBA_3_0/source/auth SAMBA_3_0/source/groupdb SAMBA_3_0/source/lib SAMBA_3_0/source/nsswitch SAMBA_3_0/source/passdb SAMBA_3_0/source/rpcclient SAMBA_3_0/source/smbd SAMBA_3_0_24/source/auth SAMBA_3_0_24/source/groupdb SAMBA_3_0_24/source/lib SAMBA_3_0_24/source/nsswitch SAMBA_3_0_24/source/passdb SAMBA_3_0_24/source/rpcclient SAMBA_3_0_24/source/smbd

[Jeremy Allison]

On Sat, Dec 09, 2006 at 08:04:59PM -0800, Jeremy Allison wrote:
> On Sat, Dec 09, 2006 at 05:05:42PM -0800, James Peach wrote:
> > 
> > But what happens to the gids that were allocated on mem_ctx by  
> > pdb_default_enum_group_memberships? Previously they were allocated on  
> > tmp_ctx which is destroyed on the way out. Now they are just left  
> > dangling. Am I missing something here?

Ok, I've now fixed this properly. We never use a null context,
and for the calls from smbd/service.c, we allocate directly
on the conn->mem_ctx as we should. I fixed the conn_free
to clean up correctly. Please check it out.

Everything in create_token_from_username() now allocates
on tmp_ctx and only the returned values of found_username
and token are allocated on the passed-in context.

Jeremy.