svn commit: samba r20013 - in branches/SAMBA_3_0/source/rpc_server: .

vlendec at samba.org vlendec at samba.org
Sun Dec 3 10:09:37 GMT 2006


Author: vlendec
Date: 2006-12-03 10:09:37 +0000 (Sun, 03 Dec 2006)
New Revision: 20013

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=20013

Log:
Fix segfaults: parm_error is a unique in/out ptr
Modified:
   branches/SAMBA_3_0/source/rpc_server/srv_srvsvc_nt.c


Changeset:
Modified: branches/SAMBA_3_0/source/rpc_server/srv_srvsvc_nt.c
===================================================================
--- branches/SAMBA_3_0/source/rpc_server/srv_srvsvc_nt.c	2006-12-02 23:01:34 UTC (rev 20012)
+++ branches/SAMBA_3_0/source/rpc_server/srv_srvsvc_nt.c	2006-12-03 10:09:37 UTC (rev 20013)
@@ -1146,7 +1146,9 @@
 WERROR _srvsvc_NetSrvSetInfo(pipes_struct *p, const char *server_unc, uint32_t level, union srvsvc_NetSrvInfo info, uint32_t *parm_error)
 {
 	/* Set up the net server set info structure. */
-	*parm_error = 0;
+	if (parm_error) {
+		*parm_error = 0;
+	}
 	return WERR_OK;
 }
 
@@ -1391,7 +1393,9 @@
 
 	DEBUG(5,("_srv_net_share_set_info: %d\n", __LINE__));
 
-	*parm_error = 0;
+	if (parm_error) {
+		*parm_error = 0;
+	}
 
 	if ( strequal(share_name,"IPC$") 
 		|| ( lp_enable_asu_support() && strequal(share_name,"ADMIN$") )
@@ -1578,7 +1582,9 @@
 
 	DEBUG(5,("_srv_net_share_add: %d\n", __LINE__));
 
-	*parm_error = 0;
+	if (parm_error) {
+		*parm_error = 0;
+	}
 
 	is_disk_op = user_has_privileges( p->pipe_user.nt_user_token,
 					  &se_diskop );



More information about the samba-cvs mailing list