svn commit: samba r19979 - in branches/SAMBA_3_0/source/smbd: .

idra at samba.org idra at samba.org
Fri Dec 1 15:04:53 GMT 2006


Author: idra
Date: 2006-12-01 15:04:53 +0000 (Fri, 01 Dec 2006)
New Revision: 19979

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=19979

Log:

Fix memleak on pw and change talloc_destroy to TALLOC_FREE for mem_ctx


Modified:
   branches/SAMBA_3_0/source/smbd/sesssetup.c


Changeset:
Modified: branches/SAMBA_3_0/source/smbd/sesssetup.c
===================================================================
--- branches/SAMBA_3_0/source/smbd/sesssetup.c	2006-12-01 14:54:31 UTC (rev 19978)
+++ branches/SAMBA_3_0/source/smbd/sesssetup.c	2006-12-01 15:04:53 UTC (rev 19979)
@@ -335,7 +335,8 @@
 			SAFE_FREE(client);
 			data_blob_free(&ap_rep);
 			data_blob_free(&session_key);
-			talloc_destroy(mem_ctx);
+			TALLOC_FREE(mem_ctx);
+			TALLOC_FREE(pw);
 			return ERROR_NT(nt_status_squash(ret));
 		}
 
@@ -348,7 +349,8 @@
 			SAFE_FREE(client);
 			data_blob_free(&ap_rep);
 			data_blob_free(&session_key);
-			talloc_destroy(mem_ctx);
+			TALLOC_FREE(mem_ctx);
+			TALLOC_FREE(pw);
 			return ERROR_NT(nt_status_squash(ret));
 		}
 
@@ -372,6 +374,7 @@
 			SAFE_FREE(client);
 			data_blob_free(&ap_rep);
 			data_blob_free(&session_key);
+			TALLOC_FREE(pw);
 			TALLOC_FREE( mem_ctx );
 			TALLOC_FREE( server_info );
 			return ERROR_NT(nt_status_squash(ret));
@@ -415,7 +418,8 @@
 	data_blob_free(&ap_rep);
 	data_blob_free(&ap_rep_wrapped);
 	data_blob_free(&response);
-	talloc_destroy(mem_ctx);
+	TALLOC_FREE(mem_ctx);
+	TALLOC_FREE(pw);
 
 	return -1; /* already replied */
 }



More information about the samba-cvs mailing list