svn commit: samba r17935 - in branches/SAMBA_3_0_RELEASE: . source/libsmb

[jerry at samba.org]

Author: jerry
Date: 2006-08-30 17:10:06 +0000 (Wed, 30 Aug 2006)
New Revision: 17935

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=17935

Log:
grab jeremy's memory leak fix and update the release notes
Modified:
   branches/SAMBA_3_0_RELEASE/WHATSNEW.txt
   branches/SAMBA_3_0_RELEASE/source/libsmb/namequery.c


Changeset:
Modified: branches/SAMBA_3_0_RELEASE/WHATSNEW.txt
===================================================================
--- branches/SAMBA_3_0_RELEASE/WHATSNEW.txt	2006-08-30 16:58:29 UTC (rev 17934)
+++ branches/SAMBA_3_0_RELEASE/WHATSNEW.txt	2006-08-30 17:10:06 UTC (rev 17935)
@@ -1,6 +1,6 @@
                    ===============================
                    Release Notes for Samba 3.0.23c
-                             Aug 29, 2006
+                             Aug 30, 2006
                    ===============================
 
 This is the latest stable release of Samba. This is the version 
@@ -78,6 +78,7 @@
     * Fix inconsistency found in checking for NULL in DLIST_REMOVE
       macro.
     * Pointer dereference fixes based on the Saturn analysis tool.
+    * Fix memory leak in the AD DC lookup code.
 
 
 o   Gerald (Jerry) Carter <jerry at samba.org>

Modified: branches/SAMBA_3_0_RELEASE/source/libsmb/namequery.c
===================================================================
--- branches/SAMBA_3_0_RELEASE/source/libsmb/namequery.c	2006-08-30 16:58:29 UTC (rev 17934)
+++ branches/SAMBA_3_0_RELEASE/source/libsmb/namequery.c	2006-08-30 17:10:06 UTC (rev 17935)
@@ -1044,6 +1044,7 @@
 		
 	status = ads_dns_query_dcs( ctx, name, &dcs, &numdcs );
 	if ( !NT_STATUS_IS_OK( status ) ) {
+		talloc_destroy(ctx);
 		return False;
 	}
 
@@ -1053,6 +1054,7 @@
 		
 	if ( (*return_iplist = SMB_MALLOC_ARRAY(struct ip_service, numaddrs)) == NULL ) {
 		DEBUG(0,("resolve_ads: malloc failed for %d entries\n", numaddrs ));
+		talloc_destroy(ctx);
 		return False;
 	}
 	
@@ -1096,8 +1098,7 @@
 			(*return_count)++;
 	}
 		
-	TALLOC_FREE( dcs );
-				
+	talloc_destroy(ctx);
 	return True;
 }