svn commit: samba r17903 - in branches: SAMBA_3_0/source/utils SAMBA_3_0_23/source/utils

[jra at samba.org]

Author: jra
Date: 2006-08-29 01:25:57 +0000 (Tue, 29 Aug 2006)
New Revision: 17903

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=17903

Log:
Fix null deref caught by Stanford checker. Don't
call ntlmssp_end on a null pointer ! (Doh !).
Jeremy.

Modified:
   branches/SAMBA_3_0/source/utils/ntlm_auth.c
   branches/SAMBA_3_0_23/source/utils/ntlm_auth.c


Changeset:
Modified: branches/SAMBA_3_0/source/utils/ntlm_auth.c
===================================================================
--- branches/SAMBA_3_0/source/utils/ntlm_auth.c	2006-08-29 01:11:02 UTC (rev 17902)
+++ branches/SAMBA_3_0/source/utils/ntlm_auth.c	2006-08-29 01:25:57 UTC (rev 17903)
@@ -1344,7 +1344,6 @@
 	if (client_ntlmssp_state == NULL) {
 		DEBUG(1, ("Got NTLMSSP tArg without a client state\n"));
 		x_fprintf(x_stdout, "BH\n");
-		ntlmssp_end(&client_ntlmssp_state);
 		return;
 	}
 

Modified: branches/SAMBA_3_0_23/source/utils/ntlm_auth.c
===================================================================
--- branches/SAMBA_3_0_23/source/utils/ntlm_auth.c	2006-08-29 01:11:02 UTC (rev 17902)
+++ branches/SAMBA_3_0_23/source/utils/ntlm_auth.c	2006-08-29 01:25:57 UTC (rev 17903)
@@ -1097,7 +1097,6 @@
 	if (client_ntlmssp_state == NULL) {
 		DEBUG(1, ("Got NTLMSSP tArg without a client state\n"));
 		x_fprintf(x_stdout, "BH\n");
-		ntlmssp_end(&client_ntlmssp_state);
 		return;
 	}