svn commit: samba r17901 - in branches: SAMBA_3_0/source/libads SAMBA_3_0_23/source/libads

[jra at samba.org]

Author: jra
Date: 2006-08-29 01:04:25 +0000 (Tue, 29 Aug 2006)
New Revision: 17901

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=17901

Log:
Stanford checker fix. cookie here can't be null or we'd
deref null. Make interface explicit.
Jeremy.

Modified:
   branches/SAMBA_3_0/source/libads/ldap.c
   branches/SAMBA_3_0_23/source/libads/ldap.c


Changeset:
Modified: branches/SAMBA_3_0/source/libads/ldap.c
===================================================================
--- branches/SAMBA_3_0/source/libads/ldap.c	2006-08-29 00:56:08 UTC (rev 17900)
+++ branches/SAMBA_3_0/source/libads/ldap.c	2006-08-29 01:04:25 UTC (rev 17901)
@@ -506,7 +506,7 @@
 	}
 
 	cookie_be = ber_alloc_t(LBER_USE_DER);
-	if (cookie && *cookie) {
+	if (*cookie) {
 		ber_printf(cookie_be, "{iO}", (ber_int_t) 1000, *cookie);
 		ber_bvfree(*cookie); /* don't need it from last time */
 		*cookie = NULL;

Modified: branches/SAMBA_3_0_23/source/libads/ldap.c
===================================================================
--- branches/SAMBA_3_0_23/source/libads/ldap.c	2006-08-29 00:56:08 UTC (rev 17900)
+++ branches/SAMBA_3_0_23/source/libads/ldap.c	2006-08-29 01:04:25 UTC (rev 17901)
@@ -496,7 +496,7 @@
 	}
 
 	cookie_be = ber_alloc_t(LBER_USE_DER);
-	if (cookie && *cookie) {
+	if (*cookie) {
 		ber_printf(cookie_be, "{iO}", (ber_int_t) 1000, *cookie);
 		ber_bvfree(*cookie); /* don't need it from last time */
 		*cookie = NULL;