svn commit: samba r17879 - in branches: SAMBA_3_0/source/smbd SAMBA_3_0_23/source/smbd

[jra at samba.org]

Author: jra
Date: 2006-08-28 05:41:32 +0000 (Mon, 28 Aug 2006)
New Revision: 17879

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=17879

Log:
Make it explicit that we can never pass NULL for buflen or stringlen.
Stanford Checker fix.
Jeremy.

Modified:
   branches/SAMBA_3_0/source/smbd/lanman.c
   branches/SAMBA_3_0_23/source/smbd/lanman.c


Changeset:
Modified: branches/SAMBA_3_0/source/smbd/lanman.c
===================================================================
--- branches/SAMBA_3_0/source/smbd/lanman.c	2006-08-28 05:35:27 UTC (rev 17878)
+++ branches/SAMBA_3_0/source/smbd/lanman.c	2006-08-28 05:41:32 UTC (rev 17879)
@@ -1195,12 +1195,8 @@
 				break;
 		}
 
-		if (buflen) {
-			*buflen = struct_len;
-		}
-		if (stringspace) {
-			*stringspace = len;
-		}
+		*buflen = struct_len;
+		*stringspace = len;
 		return struct_len + len;
 	}
   

Modified: branches/SAMBA_3_0_23/source/smbd/lanman.c
===================================================================
--- branches/SAMBA_3_0_23/source/smbd/lanman.c	2006-08-28 05:35:27 UTC (rev 17878)
+++ branches/SAMBA_3_0_23/source/smbd/lanman.c	2006-08-28 05:41:32 UTC (rev 17879)
@@ -1183,12 +1183,8 @@
 				break;
 		}
 
-		if (buflen) {
-			*buflen = struct_len;
-		}
-		if (stringspace) {
-			*stringspace = len;
-		}
+		*buflen = struct_len;
+		*stringspace = len;
 		return struct_len + len;
 	}