svn commit: samba r17877 - in branches: SAMBA_3_0/source/rpc_parse SAMBA_3_0_23/source/rpc_parse

jra at samba.org jra at samba.org
Mon Aug 28 05:27:31 GMT 2006


Author: jra
Date: 2006-08-28 05:27:30 +0000 (Mon, 28 Aug 2006)
New Revision: 17877

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=17877

Log:
Make it explicit to the checker that we can never pass
in NULL as ctr to a void returning fn.
Jeremy.

Modified:
   branches/SAMBA_3_0/source/rpc_parse/parse_samr.c
   branches/SAMBA_3_0_23/source/rpc_parse/parse_samr.c


Changeset:
Modified: branches/SAMBA_3_0/source/rpc_parse/parse_samr.c
===================================================================
--- branches/SAMBA_3_0/source/rpc_parse/parse_samr.c	2006-08-28 05:26:42 UTC (rev 17876)
+++ branches/SAMBA_3_0/source/rpc_parse/parse_samr.c	2006-08-28 05:27:30 UTC (rev 17877)
@@ -6895,8 +6895,7 @@
 	q_u->switch_value = switch_value;
 	q_u->ctr = ctr;
 
-	if (q_u->ctr != NULL)
-		q_u->ctr->switch_value = switch_value;
+	q_u->ctr->switch_value = switch_value;
 
 	switch (switch_value) {
 	case 18:

Modified: branches/SAMBA_3_0_23/source/rpc_parse/parse_samr.c
===================================================================
--- branches/SAMBA_3_0_23/source/rpc_parse/parse_samr.c	2006-08-28 05:26:42 UTC (rev 17876)
+++ branches/SAMBA_3_0_23/source/rpc_parse/parse_samr.c	2006-08-28 05:27:30 UTC (rev 17877)
@@ -6895,8 +6895,7 @@
 	q_u->switch_value = switch_value;
 	q_u->ctr = ctr;
 
-	if (q_u->ctr != NULL)
-		q_u->ctr->switch_value = switch_value;
+	q_u->ctr->switch_value = switch_value;
 
 	switch (switch_value) {
 	case 18:



More information about the samba-cvs mailing list