svn commit: samba r17874 - in branches: SAMBA_3_0/source/libsmb SAMBA_3_0_23/source/libsmb

[jra at samba.org]

Author: jra
Date: 2006-08-28 05:10:56 +0000 (Mon, 28 Aug 2006)
New Revision: 17874

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=17874

Log:
Fix possible null deref found by Stanford checker.
Jeremy.

Modified:
   branches/SAMBA_3_0/source/libsmb/namecache.c
   branches/SAMBA_3_0_23/source/libsmb/namecache.c


Changeset:
Modified: branches/SAMBA_3_0/source/libsmb/namecache.c
===================================================================
--- branches/SAMBA_3_0/source/libsmb/namecache.c	2006-08-28 04:55:05 UTC (rev 17873)
+++ branches/SAMBA_3_0/source/libsmb/namecache.c	2006-08-28 05:10:56 UTC (rev 17874)
@@ -178,14 +178,14 @@
 	char *key, *value;
 	time_t timeout;
 
-	*num_names = 0;
-
 	/* exit now if null pointers were passed as they're required further */
 	if (!ip_list || !num_names) return False;
 
 	if (!gencache_init())
 		return False;
 
+	*num_names = 0;
+
 	/* 
 	 * Use gencache interface - lookup the key
 	 */

Modified: branches/SAMBA_3_0_23/source/libsmb/namecache.c
===================================================================
--- branches/SAMBA_3_0_23/source/libsmb/namecache.c	2006-08-28 04:55:05 UTC (rev 17873)
+++ branches/SAMBA_3_0_23/source/libsmb/namecache.c	2006-08-28 05:10:56 UTC (rev 17874)
@@ -178,14 +178,14 @@
 	char *key, *value;
 	time_t timeout;
 
-	*num_names = 0;
-
 	/* exit now if null pointers were passed as they're required further */
 	if (!ip_list || !num_names) return False;
 
 	if (!gencache_init())
 		return False;
 
+	*num_names = 0;
+
 	/* 
 	 * Use gencache interface - lookup the key
 	 */