svn commit: samba r17873 - in branches: SAMBA_3_0/source/web SAMBA_3_0_23/source/web

jra at samba.org jra at samba.org
Mon Aug 28 04:55:09 GMT 2006


Author: jra
Date: 2006-08-28 04:55:05 +0000 (Mon, 28 Aug 2006)
New Revision: 17873

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=17873

Log:
Fix possible null deref found by Stanford checker.
Jeremy.

Modified:
   branches/SAMBA_3_0/source/web/cgi.c
   branches/SAMBA_3_0_23/source/web/cgi.c


Changeset:
Modified: branches/SAMBA_3_0/source/web/cgi.c
===================================================================
--- branches/SAMBA_3_0/source/web/cgi.c	2006-08-28 04:52:36 UTC (rev 17872)
+++ branches/SAMBA_3_0/source/web/cgi.c	2006-08-28 04:55:05 UTC (rev 17873)
@@ -80,8 +80,9 @@
 
 	}
 	
-
-	ret[i] = 0;
+	if (ret) {
+		ret[i] = 0;
+	}
 	return ret;
 }
 

Modified: branches/SAMBA_3_0_23/source/web/cgi.c
===================================================================
--- branches/SAMBA_3_0_23/source/web/cgi.c	2006-08-28 04:52:36 UTC (rev 17872)
+++ branches/SAMBA_3_0_23/source/web/cgi.c	2006-08-28 04:55:05 UTC (rev 17873)
@@ -80,8 +80,9 @@
 
 	}
 	
-
-	ret[i] = 0;
+	if (ret) {
+		ret[i] = 0;
+	}
 	return ret;
 }
 



More information about the samba-cvs mailing list