svn commit: samba r17461 - in branches/SAMBA_3_0/source/nsswitch: .

jra at samba.org jra at samba.org
Tue Aug 8 17:34:52 GMT 2006


Author: jra
Date: 2006-08-08 17:34:51 +0000 (Tue, 08 Aug 2006)
New Revision: 17461

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=17461

Log:
Ensure we never save a NULL SID mapping. || should be &&.
Found by Whitfield school.
Jeremy.

Modified:
   branches/SAMBA_3_0/source/nsswitch/winbindd_cache.c


Changeset:
Modified: branches/SAMBA_3_0/source/nsswitch/winbindd_cache.c
===================================================================
--- branches/SAMBA_3_0/source/nsswitch/winbindd_cache.c	2006-08-08 16:08:22 UTC (rev 17460)
+++ branches/SAMBA_3_0/source/nsswitch/winbindd_cache.c	2006-08-08 17:34:51 UTC (rev 17461)
@@ -1241,7 +1241,7 @@
 	status = domain->backend->name_to_sid(domain, mem_ctx, domain_name, name, sid, type);
 
 	/* and save it */
-	if (domain->online || !is_null_sid(sid)) {
+	if (domain->online && !is_null_sid(sid)) {
 		wcache_save_name_to_sid(domain, status, domain_name, name, sid, *type);
 	}
 



More information about the samba-cvs mailing list