svn commit: samba r17439 - in branches/SAMBA_3_0/source/rpc_server: .

jra at samba.org jra at samba.org
Mon Aug 7 15:41:43 GMT 2006


Author: jra
Date: 2006-08-07 15:41:43 +0000 (Mon, 07 Aug 2006)
New Revision: 17439

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=17439

Log:
Fix logic error in checking TALLOC return. Spotted by Volker.
Jeremy.

Modified:
   branches/SAMBA_3_0/source/rpc_server/srv_samr_nt.c


Changeset:
Modified: branches/SAMBA_3_0/source/rpc_server/srv_samr_nt.c
===================================================================
--- branches/SAMBA_3_0/source/rpc_server/srv_samr_nt.c	2006-08-07 13:39:52 UTC (rev 17438)
+++ branches/SAMBA_3_0/source/rpc_server/srv_samr_nt.c	2006-08-07 15:41:43 UTC (rev 17439)
@@ -1645,7 +1645,7 @@
 	attrs = TALLOC_ZERO_ARRAY(p->mem_ctx, enum SID_NAME_USE, num_rids);
 	wire_attrs = TALLOC_ZERO_ARRAY(p->mem_ctx, uint32, num_rids);
 
-	if ((num_rids != 0) && ((names == NULL) || (attrs == NULL) || wire_attrs))
+	if ((num_rids != 0) && ((names == NULL) || (attrs == NULL) || (wire_attrs==NULL)))
 		return NT_STATUS_NO_MEMORY;
 
 	become_root();  /* lookup_sid can require root privs */



More information about the samba-cvs mailing list