svn commit: samba r17431 - in branches: SAMBA_3_0/source/libsmb SAMBA_3_0_23/source/libsmb

[jra at samba.org]

Author: jra
Date: 2006-08-05 20:05:37 +0000 (Sat, 05 Aug 2006)
New Revision: 17431

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=17431

Log:
Fix bug #4003, reported by dale-keyword-samba.c7b741 at codefu.org.
NTcancel doesn't send a reply, so in this case the signing
sequence number is only incremented by 1, not 2.
Jeremy.

Modified:
   branches/SAMBA_3_0/source/libsmb/smb_signing.c
   branches/SAMBA_3_0_23/source/libsmb/smb_signing.c


Changeset:
Modified: branches/SAMBA_3_0/source/libsmb/smb_signing.c
===================================================================
--- branches/SAMBA_3_0/source/libsmb/smb_signing.c	2006-08-05 19:50:58 UTC (rev 17430)
+++ branches/SAMBA_3_0/source/libsmb/smb_signing.c	2006-08-05 20:05:37 UTC (rev 17431)
@@ -852,6 +852,9 @@
 
 	while (get_sequence_for_reply(&data->outstanding_packet_list, mid, &dummy_seq))
 		;
+
+	/* cancel doesn't send a reply so doesn't burn a sequence number. */
+	data->send_seq_num -= 1;
 }
 
 /***********************************************************

Modified: branches/SAMBA_3_0_23/source/libsmb/smb_signing.c
===================================================================
--- branches/SAMBA_3_0_23/source/libsmb/smb_signing.c	2006-08-05 19:50:58 UTC (rev 17430)
+++ branches/SAMBA_3_0_23/source/libsmb/smb_signing.c	2006-08-05 20:05:37 UTC (rev 17431)
@@ -847,6 +847,9 @@
 
 	while (get_sequence_for_reply(&data->outstanding_packet_list, mid, &dummy_seq))
 		;
+
+	/* cancel doesn't send a reply so doesn't burn a sequence number. */
+	data->send_seq_num -= 1;
 }
 
 /***********************************************************