svn commit: samba r15293 - in branches/SAMBA_3_0/source/smbd: .

jra at samba.org jra at samba.org
Thu Apr 27 13:42:18 GMT 2006


Author: jra
Date: 2006-04-27 13:42:18 +0000 (Thu, 27 Apr 2006)
New Revision: 15293

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=15293

Log:
Don't ever set O_SYNC on open unless "strict sync = yes".
This could be the cause of the perf. problem reported
between 3.0.14a and 3.0.2x. Lufthansa has *wireless*
on their flights to the USA now...  (I'm in heaven ! :-).
Jeremy.

Modified:
   branches/SAMBA_3_0/source/smbd/open.c


Changeset:
Modified: branches/SAMBA_3_0/source/smbd/open.c
===================================================================
--- branches/SAMBA_3_0/source/smbd/open.c	2006-04-27 09:34:31 UTC (rev 15292)
+++ branches/SAMBA_3_0/source/smbd/open.c	2006-04-27 13:42:18 UTC (rev 15293)
@@ -1308,7 +1308,7 @@
 	 */
 
 #if defined(O_SYNC)
-	if (create_options & FILE_WRITE_THROUGH) {
+	if (lp_strict_sync(SNUM(conn)) && (create_options & FILE_WRITE_THROUGH)) {
 		flags2 |= O_SYNC;
 	}
 #endif /* O_SYNC */



More information about the samba-cvs mailing list