svn commit: samba r14853 - in trunk/source/smbd: .

[Stefan (metze) Metzmacher]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

> Log:
> When going through ipc, trans2 and nttrans I had started from the 3_0
> ipc.c. Fix the bug in the 3 new implementations that Jeremy just fixed in
> 3_0/smbd/ipc.c.

> Modified: trunk/source/smbd/ipc.c
> ===================================================================
> --- trunk/source/smbd/ipc.c	2006-04-01 18:41:07 UTC (rev 14852)
> +++ trunk/source/smbd/ipc.c	2006-04-01 19:17:07 UTC (rev 14853)
> @@ -638,7 +638,7 @@
>  			goto bad_param;
>  		if (pdisp > state->total_param)
>  			goto bad_param;
> -		if ((smb_base(inbuf) + poff + pcnt >= inbuf + size) ||
> +		if ((smb_base(inbuf) + poff + pcnt > inbuf + size) ||
>  		    (smb_base(inbuf) + poff + pcnt < smb_base(inbuf)))
>  			goto bad_param;
>  		if (state->param + pdisp < state->param)

wouldn't it be better to define some macros, and use them, so only one
place needs to be updated...?

metze
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFEL8JAm70gjA5TCD8RAnAkAKCkVxWZaw0mKkUhQJtkKKiYIcPoTQCgycDq
doUT6i6enXYfDtVM5MkYR3w=
=ik0Y
-----END PGP SIGNATURE-----