svn commit: samba r10395 - in branches/SAMBA_4_0/source/libcli/resolve: .

[vlendec at samba.org]

Author: vlendec
Date: 2005-09-21 16:35:15 +0000 (Wed, 21 Sep 2005)
New Revision: 10395

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=10395

Log:
While playing with winbind, I found a segfault because I had given
resolve_name_send a stack-allocated method list. Duplicate it.

Volker

Modified:
   branches/SAMBA_4_0/source/libcli/resolve/resolve.c


Changeset:
Modified: branches/SAMBA_4_0/source/libcli/resolve/resolve.c
===================================================================
--- branches/SAMBA_4_0/source/libcli/resolve/resolve.c	2005-09-21 15:51:00 UTC (rev 10394)
+++ branches/SAMBA_4_0/source/libcli/resolve/resolve.c	2005-09-21 16:35:15 UTC (rev 10395)
@@ -133,7 +133,8 @@
 	if (!NT_STATUS_IS_OK(status)) goto failed;
 
 	if (methods == NULL) goto failed;
-	state->methods = methods;
+	state->methods = str_list_copy(state, methods);
+	if (state->methods == NULL) goto failed;
 
 	c->state = SMBCLI_REQUEST_SEND;
 	c->private = state;