svn commit: samba r10370 - in branches/SAMBA_4_0/source/torture/local: .

tridge at samba.org tridge at samba.org
Tue Sep 20 23:23:03 GMT 2005


Author: tridge
Date: 2005-09-20 23:23:03 +0000 (Tue, 20 Sep 2005)
New Revision: 10370

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=10370

Log:

only validate the re-generated binding string for hostnames with IPs

Jelmer, can you see a better approach to this? As far as I am aware
protocol towers don't use hostnames, they always use IP addresses

Modified:
   branches/SAMBA_4_0/source/torture/local/binding_string.c


Changeset:
Modified: branches/SAMBA_4_0/source/torture/local/binding_string.c
===================================================================
--- branches/SAMBA_4_0/source/torture/local/binding_string.c	2005-09-20 23:00:45 UTC (rev 10369)
+++ branches/SAMBA_4_0/source/torture/local/binding_string.c	2005-09-20 23:23:03 UTC (rev 10370)
@@ -82,7 +82,7 @@
 		return False;
 	}
 
-	if (strcasecmp(s, s2) != 0) {
+	if (is_ipaddress(b->host) && strcasecmp(s, s2) != 0) {
 		DEBUG(0, ("Mismatch while comparing original and from protocol tower generated binding strings: '%s' <> '%s'\n", s, s2));
 		return False;
 	}



More information about the samba-cvs mailing list