svn commit: samba r10369 - in branches/SAMBA_4_0/source: .

tpot at samba.org tpot at samba.org
Tue Sep 20 23:00:46 GMT 2005


Author: tpot
Date: 2005-09-20 23:00:45 +0000 (Tue, 20 Sep 2005)
New Revision: 10369

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=10369

Log:
You don't need to put leading or trailing spaces on variables.  It's
a make-ism.

Use consistent (single) quoting.

Modified:
   branches/SAMBA_4_0/source/SConstruct


Changeset:
Modified: branches/SAMBA_4_0/source/SConstruct
===================================================================
--- branches/SAMBA_4_0/source/SConstruct	2005-09-20 22:52:54 UTC (rev 10368)
+++ branches/SAMBA_4_0/source/SConstruct	2005-09-20 23:00:45 UTC (rev 10369)
@@ -22,18 +22,18 @@
 		)
 
 if hostenv['developer']:
-	hostenv.Append(CCFLAGS=' -Wall')
-	hostenv.Append(CCFLAGS=' -Wshadow')
-	hostenv.Append(CCFLAGS=' -Werror-implicit-function-declaration')
-	hostenv.Append(CCFLAGS=' -Wstrict-prototypes')
-	hostenv.Append(CCFLAGS=' -Wpointer-arith')
-	hostenv.Append(CCFLAGS=' -Wcast-qual')
-	hostenv.Append(CCFLAGS=' -Wcast-align')
-	hostenv.Append(CCFLAGS=' -Wwrite-strings')
-	hostenv.Append(CCFLAGS=' -Wmissing-format-attribute')
-	hostenv.Append(CCFLAGS=' -Wformat=2')
-	hostenv.Append(CCFLAGS=' -Wno-format-y2k')
-	hostenv.Append(CCFLAGS=' -Wno-declaration-after-statement')
+	hostenv.Append(CCFLAGS='-Wall')
+	hostenv.Append(CCFLAGS='-Wshadow')
+	hostenv.Append(CCFLAGS='-Werror-implicit-function-declaration')
+	hostenv.Append(CCFLAGS='-Wstrict-prototypes')
+	hostenv.Append(CCFLAGS='-Wpointer-arith')
+	hostenv.Append(CCFLAGS='-Wcast-qual')
+	hostenv.Append(CCFLAGS='-Wcast-align')
+	hostenv.Append(CCFLAGS='-Wwrite-strings')
+	hostenv.Append(CCFLAGS='-Wmissing-format-attribute')
+	hostenv.Append(CCFLAGS='-Wformat=2')
+	hostenv.Append(CCFLAGS='-Wno-format-y2k')
+	hostenv.Append(CCFLAGS='-Wno-declaration-after-statement')
 
 
 
@@ -58,16 +58,16 @@
 dynenv = hostenv.Copy()
 
 paths = { 
-	'BINDIR': "bin",
-	'SBINDIR': "sbin",
-	'CONFIGFILE': "cfg",
-	'LOGFILEBASE': "lfb",
-	'NCALRPCDIR': "ncalrpc",
-	'LMHOSTSFILE': "lmhosts",
-	'LIBDIR': "libdir",
-	'SHLIBEXT': "ext",
-	'LOCKDIR': "lockdir",
-	'PIDDIR': "piddir",
+	'BINDIR': 'bin',
+	'SBINDIR': 'sbin',
+	'CONFIGFILE': 'cfg',
+	'LOGFILEBASE': 'lfb',
+	'NCALRPCDIR': 'ncalrpc',
+	'LMHOSTSFILE': 'lmhosts',
+	'LIBDIR': 'libdir',
+	'SHLIBEXT': 'ext',
+	'LOCKDIR': 'lockdir',
+	'PIDDIR': 'piddir',
 	'PRIVATE_DIR': 'private',
 	'SWATDIR': 'swat'
 }



More information about the samba-cvs mailing list